Pixelmon Mod - Bug tracker

Pixelmon 5.1.1 - Temple Stairs not connecting correctly in certain situations while upside-down fix completed for upcoming version

Ticket description:
The Temple Stairs block incorrectly adapts to having another stair block placed perpendicular to it when both blocks are upside-down. This can cause a graphical rendering glitch where the texture of any block adjacent to what should be the 'back' of the corner stair is incorrectly rendered, allowing players to see through the world.

See the following images for examples of this:

This is a pattern of five stair blocks, with the one in the corner facing the same way as the left stairs. The corner block transforms as if the right stairs are facing the opposite direction, and because there is a block adjacent to it, it creates the glitch described above.
Image

This is a U-shape of stairs, with the bottom three all facing the same direction. As you can see, the stairs at the corners transform as if the top stairs are facing the opposite way.
Image

This is a similar arrangement as the previous one, with the orientation of all the stairs reversed. A similar error occurs, with the corner stairs turning the wrong way.
Image

Speaking as someone with a very basic understanding of Java, it seems as though half of the method is working correctly in that it
prevents rendering in the correct places. The section that renders the texture for a corner stair appears to be the issue. I would suggest that this is a simple fix, as the code renders the 'left-facing' texture when it should render the 'right-facing' texture and vice versa. This suggests to me that swapping the action taken to render a 'left-facing' texture and 'right-facing' texture should fix the problem.

Comments

No comments have been made

Ticket details

  • Ticket ID: 12371
  • Project: Pixelmon Mod
  • Status: Fix completed for upcoming version
  • Component: Graphics
  • Project version: 5.x.x
  • Priority: Normal
  • Severity: Normal
  • Forge/Sponge: (unknown)
  • What else would be useful to know?: (unknown)
  • Assigned to: Some Body
  • Reported by: ArkarianUK (Send PM)
  • Reporter's tickets: (List all tickets)
  • Reported on: 22 Jun 2017 19:59
  • Ticket last visited by: XpanD on 23 Jun 2017 06:47
JOIN THE TEAM