Pixelmon Mod - Bug tracker

[9.0.0] Camera item causes error in console fix completed

Ticket description:
The camera appears to function correctly, but is generating a console error on use.

Code: Select all[25May2022 02:51:39.623] [Server thread/FATAL] [net.minecraft.util.concurrent.ThreadTaskExecutor/]: Error executing task on Server
java.lang.ArrayIndexOutOfBoundsException: Index -1 out of bounds for length 36
   at java.util.Arrays$ArrayList.get(Arrays.java:4351) ~[?:?]
   at net.minecraft.util.NonNullList.get(SourceFile:46) ~[?:?]
   at net.minecraft.entity.player.PlayerInventory.func_70301_a(PlayerInventoryMixin.java:486) ~[?:?]
   at com.pixelmonmod.pixelmon.comm.packetHandlers.camera.ItemCameraPacket.clearMatchingItems(ItemCameraPacket.java:97) ~[pixelmon:1.16.5-9.0.0]
   at com.pixelmonmod.pixelmon.comm.packetHandlers.camera.ItemCameraPacket.handlePacket(ItemCameraPacket.java:78) ~[pixelmon:1.16.5-9.0.0]
   at com.pixelmonmod.pixelmon.comm.data.AbstractPixelmonPacket.lambda$handle$0(AbstractPixelmonPacket.java:49) ~[pixelmon:1.16.5-9.0.0]
   at net.minecraftforge.fml.network.NetworkEvent$Context.enqueueWork(NetworkEvent.java:215) ~[forge:?]
   at com.pixelmonmod.pixelmon.comm.data.AbstractPixelmonPacket.handle(AbstractPixelmonPacket.java:48) ~[pixelmon:1.16.5-9.0.0]
   at com.pixelmonmod.pixelmon.comm.PacketRegistry.handle(PacketRegistry.java:451) ~[pixelmon:1.16.5-9.0.0]
   at net.minecraftforge.fml.network.simple.IndexedMessageCodec.lambda$tryDecode$3(IndexedMessageCodec.java:128) ~[forge:?]
   at java.util.Optional.ifPresent(Optional.java:183) ~[?:?]
   at net.minecraftforge.fml.network.simple.IndexedMessageCodec.tryDecode(IndexedMessageCodec.java:128) ~[forge:?]
   at net.minecraftforge.fml.network.simple.IndexedMessageCodec.consume(IndexedMessageCodec.java:162) ~[forge:?]
   at net.minecraftforge.fml.network.simple.SimpleChannel.networkEventListener(SimpleChannel.java:80) ~[forge:?]
   at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:247) ~[eventbus-4.0.0.jar:?]
   at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:239) ~[eventbus-4.0.0.jar:?]
   at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) ~[eventbus-4.0.0.jar:?]
   at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) ~[eventbus-4.0.0.jar:?]
   at net.minecraftforge.fml.network.NetworkInstance.dispatch(NetworkInstance.java:86) ~[forge:?]
   at net.minecraftforge.fml.network.NetworkHooks.lambda$onCustomPayload$1(NetworkHooksMixin.java:91) ~[forge:?]
   at java.util.Optional.map(Optional.java:265) ~[?:?]
   at net.minecraftforge.fml.network.NetworkHooks.onCustomPayload(NetworkHooksMixin.java:91) ~[forge:?]
   at net.minecraft.network.play.ServerPlayNetHandler.func_147349_a(ServerPlayNetHandlerMixin.java:1413) ~[?:?]
   at net.minecraft.network.play.client.CCustomPayloadPacket.func_148833_a(CCustomPayloadPacket.java:42) ~[?:?]
   at net.minecraft.network.play.client.CCustomPayloadPacket.func_148833_a(CCustomPayloadPacket.java:12) ~[?:?]
   at net.minecraft.network.PacketThreadUtil.mdc7a309$lambda$checkThreadAndEnqueue$0$0(PacketThreadUtilMixin.java:536) ~[?:?]
   at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18) ~[?:?]
   at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) ~[?:?]
   at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?]
   at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServerMixin.java:734) ~[?:?]
   at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServerMixin.java:159) ~[?:?]
   at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) ~[?:?]
   at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServerMixin.java:717) ~[?:?]
   at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServerMixin.java:711) ~[?:?]
   at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213161_c(SourceFile:127) ~[?:?]
   at net.minecraft.server.MinecraftServer.func_213202_o(MinecraftServerMixin.java:697) ~[?:?]
   at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServerMixin.java:1903) ~[?:?]
   at net.minecraft.server.MinecraftServer.func_240783_a_(MinecraftServerMixin.java:232) ~[?:?]
   at java.lang.Thread.run(Thread.java:829) [?:?]

Comments

#25485 Posted by Katzyn » 25 May 2022 22:06

Hi there, could you please provide more information? I have only tested this in singleplayer and on a Mohist MP server and was not able to reporuce this issue.

#25541 Posted by reiyooki » 26 May 2022 17:27

Just had someone test it again. It appears the issue might actually be related to putting the photos on a player's head to "wear" the pokemon.

Not sure if it's specific to Arclight or not, but that's what we're running on right now.

#25729 Posted by Katzyn » 29 May 2022 06:42

Hmm, I have a friend running an arclight server, and they weren't able to reproduce it either. Could it be related to another mod, or plugin? I'm at a bit of a loss with this one...

ETA - might just ask a dev to take a peek for me!

#25735 Posted by Katzyn » 29 May 2022 07:37

Yep, gonna just forward this to Internal, thanks for the patience and sorry for the delay!

#25739 Posted by Rasgnarok » 29 May 2022 11:01

We need you to confirm this only happens on Arclight, @reiyooki. Forge servers are easy to setup and we need to see if this is only because of Arclight's integration.

#25743 Posted by reiyooki » 29 May 2022 14:24

Will test later tonight when I get home.

#25766 Posted by reiyooki » 29 May 2022 20:22

Tested with only Forge 36.2.35 & Reforged 9.0.0 on server. Here's the full latest.log from bootup to shutdown. (All I did was connect, get a starter, camera, film, then take the photo and check console.
latest.log Pastebin: https://pastebin.com/vMN8Ybj5
debug.log Pastebin: https://pastebin.com/xTAcDFAz

Client connected with the following mods (If that matters)
Image

#27906 Posted by LordSamosa » 21 Sep 2022 07:55

Fixed in 9.0.8. If this continues to be an issue, please make a new ticket. Closing.

Ticket details

  • Ticket ID: 17549
  • Project: Pixelmon Mod
  • Status: Fix completed
  • Component: Error
  • Project version: 1.16.5-9.x.x
  • Priority: Normal
  • Severity: Normal
  • Forge/Sponge: Forge: 1.16.5-36.2.26, Arclight: 1.0.22, JDK 11
  • What else would be useful to know?: (unknown)
  • Assigned to: Katzyn
  • Reported by: reiyooki (Send PM)
  • Reporter's tickets: (List all tickets)
  • Reported on: 24 May 2022 21:57
  • Ticket last visited by: LordSamosa on 21 Sep 2022 07:55
JOIN THE TEAM