Pixelmon Mod - Bug tracker

[9.0.1] PixelmonItems#getPokeballListWithMaster() doesn't work properly pending

Ticket description:
This is PixelmonItems#getPokeballListWithMaster():
Code: Select all  public static ArrayList<Item> getPokeballListWithMaster() {
    if (pokeballList == null)
      pokeballList = initializePokeballList();
    ArrayList<Item> temp = pokeballList; // should copy pokeballList - not directly add to it
    temp.add(master_ball);
    temp.add(park_ball);
    return temp;
  }

Instead of copying the regular pokeballList and adding Master Ball and Park Ball to it, it directly adds Master Ball and Park Ball to the pokeballList every time it is called.

Comments

#27309 Posted by DanielN » 05 Aug 2022 18:16

Confirmed. Moving to internal.

Ticket details

  • Ticket ID: 18040
  • Project: Pixelmon Mod
  • Status: Pending
  • Component: Other
  • Project version: 1.16.5-9.x.x
  • Priority: Normal
  • Severity: Normal
  • Forge/Sponge: (unknown)
  • What else would be useful to know?: (unknown)
  • Assigned to: DanielN
  • Reported by: Furgl (Send PM)
  • Reporter's tickets: (List all tickets)
  • Reported on: 07 Jun 2022 10:44
  • Ticket last visited by: Sophie847 on 17 Oct 2022 02:35
JOIN THE TEAM