Pixelmon Mod - Bug tracker

Shopkeepers inventory not opening fix completed

Ticket description:
On the newest version 9.0.6 of Pixelmon many, not all, of the shopkeepers inventories in villages and pokemarkts aren't opening. This happens sometimes too with just normal questgiving villagers

Comments

#27142 Posted by Sophie847 » 23 Jul 2022 02:08

Hi there,

I can confirm that most shopkeeper inventories are not opening, only NPCs of the types "Pokemart Main 1", "Pokemart Main 2" and "Spawn 1" are currently working. Attempting to speak to any others does not provoke a response from the NPC, and the following error appears in logs:
Code: Select all[23Jul2022 16:52:57.554] [Server thread/FATAL] [net.minecraft.util.concurrent.ThreadTaskExecutor/]: Error executing task on Server
java.lang.NullPointerException: null
   at com.pixelmonmod.pixelmon.entities.npcs.registry.NPCRegistryShopkeepers.getTranslatedName(NPCRegistryShopkeepers.java:345) ~[?:1.16.5-9.0.6]
   at com.pixelmonmod.pixelmon.entities.npcs.NPCShopkeeper.getShopkeeperName(NPCShopkeeper.java:264) ~[?:1.16.5-9.0.6]
   at com.pixelmonmod.pixelmon.entities.npcs.NPCShopkeeper.sendItemsToPlayer(NPCShopkeeper.java:167) ~[?:1.16.5-9.0.6]
   at com.pixelmonmod.pixelmon.entities.npcs.NPCShopkeeper.interactWithNPC(NPCShopkeeper.java:148) ~[?:1.16.5-9.0.6]
   at com.pixelmonmod.pixelmon.entities.npcs.NPCEntity.func_184199_a(NPCEntity.java:495) ~[?:1.16.5-9.0.6]
   at net.minecraft.network.play.ServerPlayNetHandler.func_147340_a(ServerPlayNetHandler.java:1197) ~[?:?]
   at net.minecraft.network.play.client.CUseEntityPacket.func_148833_a(SourceFile:74) ~[?:?]
   at net.minecraft.network.play.client.CUseEntityPacket.func_148833_a(SourceFile:13) ~[?:?]
   at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21) ~[?:?]
   at net.minecraft.network.PacketThreadUtil$$Lambda$9370/1128640561.run(Unknown Source) ~[?:?]
   at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18) ~[?:?]
   at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) [?:?]
   at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) [?:?]
   at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:734) [?:?]
   at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:159) [?:?]
   at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) [?:?]
   at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:717) [?:?]
   at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServer.java:711) [?:?]
   at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103) [?:?]
   at net.minecraft.server.MinecraftServer.func_213202_o(MinecraftServer.java:696) [?:?]
   at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:646) [?:?]
   at net.minecraft.server.MinecraftServer.func_240783_a_(MinecraftServer.java:232) [?:?]
   at net.minecraft.server.MinecraftServer$$Lambda$8631/1552593595.run(Unknown Source) [?:?]
   at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51]


As this is still occuring on the latest dev build, I will pass this to the internal tracker to be further investigated.

As for the quest givers - I wasn't able to reproduce, they all seemed to be responsive in my testing. If you any further information on how to reproduce this issue with quest givers, would you be able to open a new ticket with these details?

#27428 Posted by Sophie847 » 12 Aug 2022 11:06

I can confirm the issue with shopkeeper NPCs is now fixed with the release of 9.0.7 - all types of shopkeeper NPCs can now open their inventories again. Thanks for the report!

Ticket details

  • Ticket ID: 18656
  • Project: Pixelmon Mod
  • Status: Fix completed
  • Component: Other
  • Project version: 1.16.5-9.x.x
  • Priority: Normal
  • Severity: Normal
  • Forge/Sponge: (unknown)
  • What else would be useful to know?: (unknown)
  • Assigned to: Sophie847
  • Reported by: XxDDBxX (Send PM)
  • Reporter's tickets: (List all tickets)
  • Reported on: 21 Jul 2022 10:48
  • Ticket last visited by: Kadinu on 14 Sep 2022 09:41
JOIN THE TEAM