Pixelmon Mod - Bug tracker

Cant buy TCG booster packs, I have full jars but the NPC wont let me buy them fix completed

Ticket description:
I have full light grey essence jars to buy the base set booster pack but whenever I put the jars in the slot it wont let me buy them with the jars, I also cant just click the icon on the side of the display to buy them, whenever I try both ways the NPC makes the upset villager noise.

Comments

#28657 Posted by VecnaWard » 28 Nov 2022 05:39

This appears to be caused by having buyB set to minecraft:air, it should instead just be left out of the trade if a second requirement isn't needed.

Tested with examples I took from a spawned trader which wouldn't let me trade a full jar, upon altering the trade to something like the below with no buyB for air the trade was then possible.
Code: Select all{maxUses:2147483647,buy:{id:"tcg:essence_jar",Count:1,tag:{BlockEntityTag:{EssenceJarPercent:1.0d,EssenceJarColorBlue:170,EssenceJarColorName:'{"translate": "color.minecraft.blue"}',EssenceJarCount:100,EssenceJarColorRed:60,EssenceJarColorGreen:68}}},sell:{id:"tcg:card_back",Count:1,tag:{CardBackID:"Standard",display:{Name:'{"text":"Standard"}'}}},xp:0,rewardExp:0b}


To be clear, buyB does work if given a reference the player can actually provide as I've successfully done two items for one style trades, but it's an optional bit of the data. I suspect this buyB air is the cause of most if not all the trade issues present, though I can't easily access them all to confirm.

#28658 Posted by VecnaWard » 28 Nov 2022 06:18

Forgot to specify, it's the minecraft:air having a count of 1 which is the problem. Setting it to 0 or removing it from the trade's data, which should default to air with a count 0 if removed, fixes the trades.

#28724 Posted by Sophie847 » 09 Dec 2022 12:24

Can confirm that the NPCs will not accept essence jars for trade currently! I found this to be caused by a typo in the NBT of the jar colour. If using a glowstone dust instead of a dye (this grants a random coloured jar), then the jar is usable, but all others (ones crafted with a specifc colour) will not be accpeted by the NPC.

I wrote a datapack as a temporary solution to this, which can be found in the #data-packs channel of the pixelmon discord, and I will also move this information to the internal tracker to be properly resolved. Thanks for the report!

#28957 Posted by Sophie847 » 17 Jan 2023 16:24

Confirmed this is fixed with the release of pixelmon 9.1.1!

Ticket details

  • Ticket ID: 19596
  • Project: Pixelmon Mod
  • Status: Fix completed
  • Component: Other
  • Project version: 1.16.5-9.x.x
  • Priority: Normal
  • Severity: Normal
  • Forge/Sponge: Forge 1.16.5 - 36.2.39
  • What else would be useful to know?: JEI, Travelers Backpack, journeymap, Optifine all up to date for the version I'm playing on
  • Assigned to: Sophie847
  • Reported by: lookURgarb (Send PM)
  • Reporter's tickets: (List all tickets)
  • Reported on: 28 Nov 2022 02:59
  • Ticket last visited by: Sophie847 on 23 Jan 2023 20:10
JOIN THE TEAM