Pixelmon Mod - Bug tracker

[9.2.8] Missing method to generate 9th generation TMs pending

Ticket description:
I discovered when making wiki ui
The createTMStackFor method in PixelmonItems is missing the part to create Gen9TechnicalMachines

As a result, any attempt to create an ItemStack will return null.

Code: Select all public static ItemStack createTMStackFor(ITechnicalMove move, int count) {
        CompoundTag compound = new CompoundTag();
        compound.m_128376_("tm", (short)move.getId());
        ItemStack stack;
        if (move instanceof Gen8TechnicalRecords) {
            stack = new ItemStack(tr_gen8, count);
        } else if (move instanceof Gen8TechnicalMachines) {
            stack = new ItemStack(tm_gen8, count);
        } else if (move instanceof Gen7TechnicalMachines) {
            stack = new ItemStack(tm_gen7, count);
        } else if (move instanceof Gen6TechnicalMachines) {
            stack = new ItemStack(tm_gen6, count);
        } else if (move instanceof Gen5TechnicalMachines) {
            stack = new ItemStack(tm_gen5, count);
        } else if (move instanceof Gen4TechnicalMachines) {
            stack = new ItemStack(tm_gen4, count);
        } else if (move instanceof Gen3TechnicalMachines) {
            stack = new ItemStack(tm_gen3, count);
        } else if (move instanceof Gen2TechnicalMachines) {
            stack = new ItemStack(tm_gen2, count);
        } else {
            if (!(move instanceof Gen1TechnicalMachines)) {
                return null;
            }

            stack = new ItemStack(tm_gen1, count);
        }

        stack.m_41751_(compound);
        return stack;
    }

Comments

#31876 Posted by Sophie847 » 27 Aug 2024 00:24

Hi there,

I have been able to confirm this issue on both 9.2.8 (for 1.20.2) and 9.1.12 (for 1.16.5) - there's simply a check for generation 9 TMs missing from the method. Moving to internal for a fix now, thanks!

Ticket details

  • Ticket ID: 21985
  • Project: Pixelmon Mod
  • Status: Pending
  • Component: Error
  • Project version: 1.20.2-9.x.x
  • Priority: Normal
  • Severity: Normal
  • Forge/Sponge: Forge 1.20.2 48.1.0
  • What else would be useful to know?: Java17
  • Assigned to: Sophie847
  • Reported by: GT86 (Send PM)
  • Reporter's tickets: (List all tickets)
  • Reported on: 24 Jul 2024 07:41
  • Ticket last visited by: Rasgnarok on 06 Oct 2024 17:09
JOIN THE TEAM